soc: fsl: qe: drop pointless check in qe_sdma_init()
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Thu, 28 Nov 2019 14:55:47 +0000 (15:55 +0100)
committerLi Yang <leoyang.li@nxp.com>
Mon, 9 Dec 2019 19:54:36 +0000 (13:54 -0600)
The sdma member of struct qe_immap is not at offset zero, so even if
qe_immr wasn't initialized yet (i.e. NULL), &qe_immr->sdma would not
be NULL.

Reviewed-by: Timur Tabi <timur@kernel.org>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
drivers/soc/fsl/qe/qe.c

index 5bf279c..96c2057 100644 (file)
@@ -367,9 +367,6 @@ static int qe_sdma_init(void)
        struct sdma __iomem *sdma = &qe_immr->sdma;
        static s32 sdma_buf_offset = -ENOMEM;
 
-       if (!sdma)
-               return -ENODEV;
-
        /* allocate 2 internal temporary buffers (512 bytes size each) for
         * the SDMA */
        if (sdma_buf_offset < 0) {