soc: fsl: qe: drop use of IS_ERR_VALUE in qe_sdma_init()
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Thu, 28 Nov 2019 14:55:46 +0000 (15:55 +0100)
committerLi Yang <leoyang.li@nxp.com>
Mon, 9 Dec 2019 19:54:36 +0000 (13:54 -0600)
Now that qe_muram_alloc() returns s32, adapt qe_sdma_init() and avoid
another few IS_ERR_VALUE() uses.

Reviewed-by: Timur Tabi <timur@kernel.org>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
drivers/soc/fsl/qe/qe.c

index ec51184..5bf279c 100644 (file)
@@ -365,16 +365,16 @@ EXPORT_SYMBOL(qe_put_snum);
 static int qe_sdma_init(void)
 {
        struct sdma __iomem *sdma = &qe_immr->sdma;
-       static unsigned long sdma_buf_offset = (unsigned long)-ENOMEM;
+       static s32 sdma_buf_offset = -ENOMEM;
 
        if (!sdma)
                return -ENODEV;
 
        /* allocate 2 internal temporary buffers (512 bytes size each) for
         * the SDMA */
-       if (IS_ERR_VALUE(sdma_buf_offset)) {
+       if (sdma_buf_offset < 0) {
                sdma_buf_offset = qe_muram_alloc(512 * 2, 4096);
-               if (IS_ERR_VALUE(sdma_buf_offset))
+               if (sdma_buf_offset < 0)
                        return -ENOMEM;
        }