power: supply: bq25980: remove redundant zero check on ret
authorColin Ian King <colin.king@canonical.com>
Tue, 6 Oct 2020 17:06:00 +0000 (18:06 +0100)
committerSebastian Reichel <sre@kernel.org>
Thu, 8 Oct 2020 21:31:01 +0000 (23:31 +0200)
Currently ret is assigned to zero and the following statement checks
if it is non-zero. This check is redundant and can be removed

Addresses-Coverity: ("Logically dead code")
Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx family")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/bq25980_charger.c

index 3995fb7..f04f9ac 100644 (file)
@@ -613,9 +613,6 @@ static int bq25980_set_battery_property(struct power_supply *psy,
        struct bq25980_device *bq = power_supply_get_drvdata(psy);
        int ret = 0;
 
-       if (ret)
-               return ret;
-
        switch (psp) {
        case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
                ret = bq25980_set_const_charge_curr(bq, val->intval);