From 4b464bad37c65492f03fe6cc15bdb6a9a6a5f5e7 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Tue, 6 Oct 2020 18:06:00 +0100 Subject: [PATCH] power: supply: bq25980: remove redundant zero check on ret Currently ret is assigned to zero and the following statement checks if it is non-zero. This check is redundant and can be removed Addresses-Coverity: ("Logically dead code") Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx family") Signed-off-by: Colin Ian King Acked-by: Dan Murphy Signed-off-by: Sebastian Reichel --- drivers/power/supply/bq25980_charger.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/power/supply/bq25980_charger.c b/drivers/power/supply/bq25980_charger.c index 3995fb7cf060..f04f9acdb13b 100644 --- a/drivers/power/supply/bq25980_charger.c +++ b/drivers/power/supply/bq25980_charger.c @@ -613,9 +613,6 @@ static int bq25980_set_battery_property(struct power_supply *psy, struct bq25980_device *bq = power_supply_get_drvdata(psy); int ret = 0; - if (ret) - return ret; - switch (psp) { case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT: ret = bq25980_set_const_charge_curr(bq, val->intval); -- 2.20.1