drivers/lightnvm: fix a null-ptr-deref bug in pblk-core.c
authortangzhenhao <tzh18@mails.tsinghua.edu.cn>
Mon, 30 Nov 2020 07:23:56 +0000 (23:23 -0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 8 Dec 2020 17:02:45 +0000 (10:02 -0700)
At line 294 in drivers/lightnvm/pblk-write.c, function pblk_gen_run_ws is
called with actual param GFP_ATOMIC. pblk_gen_run_ws call mempool_alloc
using "GFP_ATOMIC" flag, so mempool_alloc can return null. So we need to
check the return-val of mempool_alloc to avoid null-ptr-deref bug.

Signed-off-by: tangzhenhao <tzh18@mails.tsinghua.edu.cn>
Reviewed-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/lightnvm/pblk-core.c

index 97c6873..1dddba1 100644 (file)
@@ -1869,6 +1869,10 @@ void pblk_gen_run_ws(struct pblk *pblk, struct pblk_line *line, void *priv,
        struct pblk_line_ws *line_ws;
 
        line_ws = mempool_alloc(&pblk->gen_ws_pool, gfp_mask);
+       if (!line_ws) {
+               pblk_err(pblk, "pblk: could not allocate memory\n");
+               return;
+       }
 
        line_ws->pblk = pblk;
        line_ws->line = line;