perf srccode: Use list_move() instead of equivalent list_del() + list_add() sequence
authorZou Wei <zou_wei@huawei.com>
Tue, 8 Jun 2021 00:52:46 +0000 (08:52 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 8 Jun 2021 12:36:36 +0000 (09:36 -0300)
Using list_move() instead of list_del() + list_add(), shorter,
equivalent.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/1623113566-49455-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/srccode.c

index c29edaa..476e998 100644 (file)
@@ -97,8 +97,7 @@ static struct srcfile *find_srcfile(char *fn)
        hlist_for_each_entry (h, &srcfile_htab[hval], hash_nd) {
                if (!strcmp(fn, h->fn)) {
                        /* Move to front */
-                       list_del(&h->nd);
-                       list_add(&h->nd, &srcfile_list);
+                       list_move(&h->nd, &srcfile_list);
                        return h;
                }
        }