drm/omapdrm: Use backlight_enable/disable helpers
authorMeghana Madhyastha <meghana.madhyastha@gmail.com>
Wed, 24 Jan 2018 16:40:12 +0000 (16:40 +0000)
committerSean Paul <seanpaul@chromium.org>
Tue, 20 Feb 2018 16:07:22 +0000 (11:07 -0500)
Use backlight_enable/disable helpers instead of changing
the property and calling backlight_update_status for cleaner
and simpler code and also to avoid repetitions.

Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/30d5b26c3c7d75de3d2ab3cff9dee67084fc3caf.1516810725.git.meghana.madhyastha@gmail.com
drivers/gpu/drm/omapdrm/displays/panel-dpi.c

index efff6db..2d8b0a3 100644 (file)
@@ -87,11 +87,7 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev)
        }
 
        gpiod_set_value_cansleep(ddata->enable_gpio, 1);
-
-       if (ddata->backlight) {
-               ddata->backlight->props.power = FB_BLANK_UNBLANK;
-               backlight_update_status(ddata->backlight);
-       }
+       backlight_enable(ddata->backlight);
 
        dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;
 
@@ -106,10 +102,7 @@ static void panel_dpi_disable(struct omap_dss_device *dssdev)
        if (!omapdss_device_is_enabled(dssdev))
                return;
 
-       if (ddata->backlight) {
-               ddata->backlight->props.power = FB_BLANK_POWERDOWN;
-               backlight_update_status(ddata->backlight);
-       }
+       backlight_disable(ddata->backlight);
 
        gpiod_set_value_cansleep(ddata->enable_gpio, 0);
        regulator_disable(ddata->vcc_supply);