rtc: goldfish: Use correct return value for goldfish_rtc_probe()
authorTiezhu Yang <yangtiezhu@loongson.cn>
Mon, 25 May 2020 01:39:47 +0000 (09:39 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 30 May 2020 02:12:34 +0000 (04:12 +0200)
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1590370788-15136-1-git-send-email-yangtiezhu@loongson.cn
drivers/rtc/rtc-goldfish.c

index cb6b0ad..2779715 100644 (file)
@@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, rtcdrv);
        rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(rtcdrv->base))
-               return -ENODEV;
+               return PTR_ERR(rtcdrv->base);
 
        rtcdrv->irq = platform_get_irq(pdev, 0);
        if (rtcdrv->irq < 0)