platform/x86: acer-wmi: Don't use ACPI_EXCEPTION()
authorHans de Goede <hdegoede@redhat.com>
Thu, 4 Feb 2021 14:02:05 +0000 (15:02 +0100)
committerHans de Goede <hdegoede@redhat.com>
Thu, 4 Feb 2021 14:15:19 +0000 (15:15 +0100)
ACPI_EXCEPTION is only intended for internal use by the ACPICA code.

ACPI_EXCEPTION was being used here to change the apci_status code into
something human-readable, use acpi_format_exception() for this instead,
which is the proper way to do this outside of ACPICA.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210204140205.268344-1-hdegoede@redhat.com
drivers/platform/x86/acer-wmi.c

index c1a5357..85db940 100644 (file)
@@ -30,7 +30,6 @@
 #include <linux/input/sparse-keymap.h>
 #include <acpi/video.h>
 
-ACPI_MODULE_NAME(KBUILD_MODNAME);
 MODULE_AUTHOR("Carlos Corbacho");
 MODULE_DESCRIPTION("Acer Laptop WMI Extras Driver");
 MODULE_LICENSE("GPL");
@@ -1605,7 +1604,8 @@ static void acer_kbd_dock_get_initial_state(void)
 
        status = wmi_evaluate_method(WMID_GUID3, 0, 0x2, &input_buf, &output_buf);
        if (ACPI_FAILURE(status)) {
-               ACPI_EXCEPTION((AE_INFO, status, "Error getting keyboard-dock initial status"));
+               pr_err("Error getting keyboard-dock initial status: %s\n",
+                      acpi_format_exception(status));
                return;
        }