nvme: warn of unhandled effects only once
authorKeith Busch <kbusch@kernel.org>
Wed, 17 Mar 2021 20:33:41 +0000 (13:33 -0700)
committerChristoph Hellwig <hch@lst.de>
Fri, 2 Apr 2021 16:48:28 +0000 (18:48 +0200)
We don't need to repeatedly spam the kernel logs with the same warning
about unhandled passthrough IO effects. Just one warning is sufficient
to observe this condition occurs.

Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c

index c3f94eb..40215a0 100644 (file)
@@ -1072,9 +1072,9 @@ u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode)
                if (ns->head->effects)
                        effects = le32_to_cpu(ns->head->effects->iocs[opcode]);
                if (effects & ~(NVME_CMD_EFFECTS_CSUPP | NVME_CMD_EFFECTS_LBCC))
-                       dev_warn(ctrl->device,
-                                "IO command:%02x has unhandled effects:%08x\n",
-                                opcode, effects);
+                       dev_warn_once(ctrl->device,
+                               "IO command:%02x has unhandled effects:%08x\n",
+                               opcode, effects);
                return 0;
        }