openvswitch: Warn over-mtu packets only if iface is UP.
authorFlavio Leitner <fbl@sysclose.org>
Tue, 16 Mar 2021 20:14:27 +0000 (17:14 -0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Mar 2021 23:28:30 +0000 (16:28 -0700)
It is not unusual to have the bridge port down. Sometimes
it has the old MTU, which is fine since it's not being used.

However, the kernel spams the log with a warning message
when a packet is going to be sent over such port. Fix that
by warning only if the interface is UP.

Signed-off-by: Flavio Leitner <fbl@sysclose.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/vport.c

index 4ed7e52..88deb5b 100644 (file)
@@ -497,10 +497,12 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
 
        if (unlikely(packet_length(skb, vport->dev) > mtu &&
                     !skb_is_gso(skb))) {
-               net_warn_ratelimited("%s: dropped over-mtu packet: %d > %d\n",
-                                    vport->dev->name,
-                                    packet_length(skb, vport->dev), mtu);
                vport->dev->stats.tx_errors++;
+               if (vport->dev->flags & IFF_UP)
+                       net_warn_ratelimited("%s: dropped over-mtu packet: "
+                                            "%d > %d\n", vport->dev->name,
+                                            packet_length(skb, vport->dev),
+                                            mtu);
                goto drop;
        }