putname(): IS_ERR_OR_NULL() is wrong here
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 7 Sep 2021 20:14:05 +0000 (16:14 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 7 Sep 2021 20:14:05 +0000 (16:14 -0400)
Mixing NULL and ERR_PTR() just in case is a Bad Idea(tm).  For
struct filename the former is wrong - failures are reported
as ERR_PTR(...), not as NULL.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namei.c

index bbb5c9b..1946d96 100644 (file)
@@ -255,7 +255,7 @@ getname_kernel(const char * filename)
 
 void putname(struct filename *name)
 {
-       if (IS_ERR_OR_NULL(name))
+       if (IS_ERR(name))
                return;
 
        BUG_ON(name->refcnt <= 0);