ALSA: hda/cs8409: Initialize Codec only in init fixup.
authorStefan Binding <sbinding@opensource.cirrus.com>
Fri, 27 Aug 2021 11:02:52 +0000 (12:02 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 27 Aug 2021 20:35:50 +0000 (22:35 +0200)
It is not necessary to initialize the codec during both probe and inside
the init fixup.

Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210827110252.5361-2-vitalyr@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_cs8409.c

index 805441b..3c7ef55 100644 (file)
@@ -1024,7 +1024,6 @@ void cs8409_cs42l42_fixups(struct hda_codec *codec, const struct hda_fixup *fix,
                                &cs42l42_adc_volume_mixer);
                /* Disable Unsolicited Response during boot */
                cs8409_enable_ur(codec, 0);
-               cs8409_cs42l42_hw_init(codec);
                snd_hda_codec_set_name(codec, "CS8409/CS42L42");
                break;
        case HDA_FIXUP_ACT_INIT:
@@ -1229,7 +1228,6 @@ void dolphin_fixups(struct hda_codec *codec, const struct hda_fixup *fix, int ac
                kctrl->private_value = HDA_COMPOSE_AMP_VAL_OFS(DOLPHIN_HP_PIN_NID, 3, CS8409_CODEC1,
                                       HDA_OUTPUT, CS42L42_VOL_DAC) | HDA_AMP_VAL_MIN_MUTE;
                cs8409_enable_ur(codec, 0);
-               dolphin_hw_init(codec);
                snd_hda_codec_set_name(codec, "CS8409/CS42L42");
                break;
        case HDA_FIXUP_ACT_INIT: