net: ethernet: ravb: Use devm_platform_get_and_ioremap_resource()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 9 Jun 2021 01:24:44 +0000 (09:24 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Jun 2021 20:51:11 +0000 (13:51 -0700)
Use devm_platform_get_and_ioremap_resource() to simplify
code.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c

index 4afff32..69c50f8 100644 (file)
@@ -2047,13 +2047,6 @@ static int ravb_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       /* Get base address */
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               dev_err(&pdev->dev, "invalid resource\n");
-               return -EINVAL;
-       }
-
        ndev = alloc_etherdev_mqs(sizeof(struct ravb_private),
                                  NUM_TX_QUEUE, NUM_RX_QUEUE);
        if (!ndev)
@@ -2065,9 +2058,6 @@ static int ravb_probe(struct platform_device *pdev)
        pm_runtime_enable(&pdev->dev);
        pm_runtime_get_sync(&pdev->dev);
 
-       /* The Ether-specific entries in the device structure. */
-       ndev->base_addr = res->start;
-
        chip_id = (enum ravb_chip_id)of_device_get_match_data(&pdev->dev);
 
        if (chip_id == RCAR_GEN3)
@@ -2089,12 +2079,15 @@ static int ravb_probe(struct platform_device *pdev)
        priv->num_rx_ring[RAVB_BE] = BE_RX_RING_SIZE;
        priv->num_tx_ring[RAVB_NC] = NC_TX_RING_SIZE;
        priv->num_rx_ring[RAVB_NC] = NC_RX_RING_SIZE;
-       priv->addr = devm_ioremap_resource(&pdev->dev, res);
+       priv->addr = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
        if (IS_ERR(priv->addr)) {
                error = PTR_ERR(priv->addr);
                goto out_release;
        }
 
+       /* The Ether-specific entries in the device structure. */
+       ndev->base_addr = res->start;
+
        spin_lock_init(&priv->lock);
        INIT_WORK(&priv->work, ravb_tx_timeout_work);