ethtool: Use explicit designated initializers for .cmd
authorLi RongQing <lirongqing@baidu.com>
Wed, 27 Feb 2019 12:47:57 +0000 (20:47 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 27 Feb 2019 18:07:57 +0000 (10:07 -0800)
Initialize the .cmd member by using a designated struct
initializer. This fixes warning of missing field initializers,
and makes code a little easier to read.

Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c

index 47558ff..d4918ff 100644 (file)
@@ -1717,7 +1717,7 @@ static noinline_for_stack int ethtool_set_channels(struct net_device *dev,
 
 static int ethtool_get_pauseparam(struct net_device *dev, void __user *useraddr)
 {
-       struct ethtool_pauseparam pauseparam = { ETHTOOL_GPAUSEPARAM };
+       struct ethtool_pauseparam pauseparam = { .cmd = ETHTOOL_GPAUSEPARAM };
 
        if (!dev->ethtool_ops->get_pauseparam)
                return -EOPNOTSUPP;
@@ -2503,7 +2503,7 @@ static int set_phy_tunable(struct net_device *dev, void __user *useraddr)
 
 static int ethtool_get_fecparam(struct net_device *dev, void __user *useraddr)
 {
-       struct ethtool_fecparam fecparam = { ETHTOOL_GFECPARAM };
+       struct ethtool_fecparam fecparam = { .cmd = ETHTOOL_GFECPARAM };
        int rc;
 
        if (!dev->ethtool_ops->get_fecparam)