drm/sched: Cancel and flush all outstanding jobs before finish.
authorAndrey Grodzovsky <andrey.grodzovsky@amd.com>
Mon, 18 Jan 2021 21:01:13 +0000 (16:01 -0500)
committerChristian König <christian.koenig@amd.com>
Tue, 19 Jan 2021 09:22:35 +0000 (10:22 +0100)
To avoid any possible use after free.

Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/414814/
CC: stable@vger.kernel.org
Signed-off-by: Christian König <christian.koenig@amd.com>
drivers/gpu/drm/scheduler/sched_main.c

index 997aa15..92637b7 100644 (file)
@@ -899,6 +899,9 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched)
        if (sched->thread)
                kthread_stop(sched->thread);
 
+       /* Confirm no work left behind accessing device structures */
+       cancel_delayed_work_sync(&sched->work_tdr);
+
        sched->ready = false;
 }
 EXPORT_SYMBOL(drm_sched_fini);