um: vector: Use GFP_ATOMIC under spin lock
authorTiezhu Yang <yangtiezhu@loongson.cn>
Fri, 19 Jun 2020 05:20:07 +0000 (13:20 +0800)
committerRichard Weinberger <richard@nod.at>
Sun, 11 Oct 2020 21:13:00 +0000 (23:13 +0200)
Use GFP_ATOMIC instead of GFP_KERNEL under spin lock to fix possible
sleep-in-atomic-context bugs.

Fixes: 9807019a62dc ("um: Loadable BPF "Firmware" for vector drivers")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/drivers/vector_kern.c

index 8735c46..555203e 100644 (file)
@@ -1403,7 +1403,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev,
                kfree(vp->bpf->filter);
                vp->bpf->filter = NULL;
        } else {
-               vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_KERNEL);
+               vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_ATOMIC);
                if (vp->bpf == NULL) {
                        netdev_err(dev, "failed to allocate memory for firmware\n");
                        goto flash_fail;
@@ -1415,7 +1415,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev,
        if (request_firmware(&fw, efl->data, &vdevice->pdev.dev))
                goto flash_fail;
 
-       vp->bpf->filter = kmemdup(fw->data, fw->size, GFP_KERNEL);
+       vp->bpf->filter = kmemdup(fw->data, fw->size, GFP_ATOMIC);
        if (!vp->bpf->filter)
                goto free_buffer;