staging: r8822be: check kzalloc return or bail
authorNicholas Mc Guire <hofrat@osadl.org>
Fri, 15 Feb 2019 09:24:22 +0000 (10:24 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Feb 2019 10:12:08 +0000 (11:12 +0100)
The kzalloc() in halmac_parse_psd_data_88xx() can fail and return NULL
so check the psd_set->data after allocation and if allocation failed
return HALMAC_CMD_PROCESS_ERROR.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-drive")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c

index 53f55f1..ec742da 100644 (file)
@@ -2466,8 +2466,11 @@ halmac_parse_psd_data_88xx(struct halmac_adapter *halmac_adapter, u8 *c2h_buf,
        segment_size = (u8)PSD_DATA_GET_SEGMENT_SIZE(c2h_buf);
        psd_set->data_size = total_size;
 
-       if (!psd_set->data)
+       if (!psd_set->data) {
                psd_set->data = kzalloc(psd_set->data_size, GFP_KERNEL);
+               if (!psd_set->data)
+                       return HALMAC_CMD_PROCESS_ERROR;
+       }
 
        if (segment_id == 0)
                psd_set->segment_size = segment_size;