net/sched: flower: add missing validation of TCA_FLOWER_FLAGS
authorDavide Caratti <dcaratti@redhat.com>
Tue, 11 Feb 2020 18:33:40 +0000 (19:33 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Feb 2020 22:16:35 +0000 (14:16 -0800)
unlike other classifiers that can be offloaded (i.e. users can set flags
like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of
netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry
to fl_policy.

Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_flower.c

index f9c0d1e..7e54d2a 100644 (file)
@@ -691,6 +691,7 @@ static const struct nla_policy fl_policy[TCA_FLOWER_MAX + 1] = {
                                            .len = 128 / BITS_PER_BYTE },
        [TCA_FLOWER_KEY_CT_LABELS_MASK] = { .type = NLA_BINARY,
                                            .len = 128 / BITS_PER_BYTE },
+       [TCA_FLOWER_FLAGS]              = { .type = NLA_U32 },
 };
 
 static const struct nla_policy