staging: rtl8712: fix the bssid in mp_start_test()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 14 May 2021 14:26:53 +0000 (17:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 14:02:51 +0000 (16:02 +0200)
We recently moved "bssid" off the stack, and allocated it with kmalloc()
instead.  Unfortunately, this one line was overlooked so it will copy
random data into the &tgt_network->network instead of the data we want.

Fixes: 0b18e5fe6008 ("staging: rtl8712: rtl871x_mp_ioctl: Move a large data struct onto the heap")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YJ6IrfkbdaTHgpEv@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_mp_ioctl.c

index adbeb46..26fa09b 100644 (file)
@@ -197,7 +197,7 @@ static int mp_start_test(struct _adapter *padapter)
        /* 3 3. join pseudo AdHoc */
        tgt_network->join_res = 1;
        tgt_network->aid = psta->aid = 1;
-       memcpy(&tgt_network->network, &bssid, length);
+       memcpy(&tgt_network->network, bssid, length);
        _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING);
        r8712_os_indicate_connect(padapter);
        /* Set to LINKED STATE for MP TRX Testing */