pwm: mediatek: Simplify using devm_pwmchip_add()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:28:11 +0000 (18:28 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 2 Sep 2021 19:38:45 +0000 (21:38 +0200)
This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-mediatek.c

index b4a3106..0d4dd80 100644 (file)
@@ -253,13 +253,11 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
                }
        }
 
-       platform_set_drvdata(pdev, pc);
-
        pc->chip.dev = &pdev->dev;
        pc->chip.ops = &pwm_mediatek_ops;
        pc->chip.npwm = pc->soc->num_pwms;
 
-       ret = pwmchip_add(&pc->chip);
+       ret = devm_pwmchip_add(&pdev->dev, &pc->chip);
        if (ret < 0) {
                dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
                return ret;
@@ -268,13 +266,6 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int pwm_mediatek_remove(struct platform_device *pdev)
-{
-       struct pwm_mediatek_chip *pc = platform_get_drvdata(pdev);
-
-       return pwmchip_remove(&pc->chip);
-}
-
 static const struct pwm_mediatek_of_data mt2712_pwm_data = {
        .num_pwms = 8,
        .pwm45_fixup = false,
@@ -335,7 +326,6 @@ static struct platform_driver pwm_mediatek_driver = {
                .of_match_table = pwm_mediatek_of_match,
        },
        .probe = pwm_mediatek_probe,
-       .remove = pwm_mediatek_remove,
 };
 module_platform_driver(pwm_mediatek_driver);