SUNRPC: change svc_get() to return the svc.

It is common for 'get' functions to return the object that was 'got',
and there are a couple of places where users of svc_get() would be a
little simpler if svc_get() did that.

Make it so.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index b220e1b..2f50d5b 100644 (file)
--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -430,14 +430,12 @@ static struct svc_serv *lockd_create_svc(void)
        /*
         * Check whether we're already up and running.
         */
-       if (nlmsvc_rqst) {
+       if (nlmsvc_rqst)
                /*
                 * Note: increase service usage, because later in case of error
                 * svc_destroy() will be called.
                 */
-               svc_get(nlmsvc_rqst->rq_server);
-               return nlmsvc_rqst->rq_server;
-       }
+               return svc_get(nlmsvc_rqst->rq_server);
 
        /*
         * Sanity check: if there's no pid,

diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
index 86d856d..6e5e742 100644 (file)
--- a/fs/nfs/callback.c
+++ b/fs/nfs/callback.c
@@ -266,14 +266,12 @@ static struct svc_serv *nfs_callback_create_svc(int minorversion)
        /*
         * Check whether we're already up and running.
         */
-       if (cb_info->serv) {
+       if (cb_info->serv)
                /*
                 * Note: increase service usage, because later in case of error
                 * svc_destroy() will be called.
                 */
-               svc_get(cb_info->serv);
-               return cb_info->serv;
-       }
+               return svc_get(cb_info->serv);
 
        switch (minorversion) {
        case 0:

diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index 0ae28ae..5d95689 100644 (file)
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -120,9 +120,10 @@ struct svc_serv {
  * change the number of threads.  Horrible, but there it is.
  * Should be called with the "service mutex" held.
  */
-static inline void svc_get(struct svc_serv *serv)
+static inline struct svc_serv *svc_get(struct svc_serv *serv)
 {
        serv->sv_nrthreads++;
+       return serv;
 }
 
 /*