pwm: sun4i: Don't update the state for the caller of pwm_apply_state()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sat, 24 Aug 2019 15:37:05 +0000 (17:37 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Fri, 20 Sep 2019 23:48:55 +0000 (01:48 +0200)
The pwm-sun4i driver is one of only three PWM drivers which updates the
state for the caller of pwm_apply_state(). This might have surprising
results if the caller reuses the values expecting them to still
represent the same state.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-sun4i.c

index de78c82..39007a7 100644 (file)
@@ -192,12 +192,6 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm,
        *dty = div;
        *prsclr = prescaler;
 
-       div = (u64)pval * NSEC_PER_SEC * *prd;
-       state->period = DIV_ROUND_CLOSEST_ULL(div, clk_rate);
-
-       div = (u64)pval * NSEC_PER_SEC * *dty;
-       state->duty_cycle = DIV_ROUND_CLOSEST_ULL(div, clk_rate);
-
        return 0;
 }