drm: simpledrm: print resource info using '%pr'
authorRandy Dunlap <rdunlap@infradead.org>
Wed, 12 May 2021 23:34:59 +0000 (16:34 -0700)
committerThomas Zimmermann <tzimmermann@suse.de>
Thu, 13 May 2021 13:02:17 +0000 (15:02 +0200)
struct resource start and end fields are not always long long,
so using %llx to print them can cause build warnings (below).
Fix these by using the special "%pr" for printing struct resource info.

../drivers/gpu/drm/tiny/simpledrm.c: In function ‘simpledrm_device_init_mm’:
../include/drm/drm_print.h:412:32: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘resource_size_t {aka unsigned int}’ [-Wformat=]
../drivers/gpu/drm/tiny/simpledrm.c:533:54: note: format string is defined here
   drm_err(dev, "could not acquire memory range [0x%llx:0x%llx]: error %d\n",
                                                   ~~~^
                                                   %x
../include/drm/drm_print.h:412:32: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘resource_size_t {aka unsigned int}’ [-Wformat=]
../drivers/gpu/drm/tiny/simpledrm.c:533:61: note: format string is defined here
   drm_err(dev, "could not acquire memory range [0x%llx:0x%llx]: error %d\n",
                                                          ~~~^
                                                          %x

Fixes: 4aae79f77e3a ("drm/simpledrm: Acquire memory aperture for framebuffer")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20210512233459.19534-1-rdunlap@infradead.org
drivers/gpu/drm/tiny/simpledrm.c

index 2bdb477..00e118c 100644 (file)
@@ -530,8 +530,8 @@ static int simpledrm_device_init_mm(struct simpledrm_device *sdev)
 
        ret = devm_aperture_acquire_from_firmware(dev, mem->start, resource_size(mem));
        if (ret) {
-               drm_err(dev, "could not acquire memory range [0x%llx:0x%llx]: error %d\n",
-                       mem->start, mem->end, ret);
+               drm_err(dev, "could not acquire memory range %pr: error %d\n",
+                       mem, ret);
                return ret;
        }