perf arm-spe: Fix endless record after being terminated
authorAdrian Hunter <adrian.hunter@intel.com>
Fri, 14 Feb 2020 13:26:53 +0000 (15:26 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 18 Feb 2020 13:13:29 +0000 (10:13 -0300)
In __cmd_record(), when receiving SIGINT(ctrl + c), a 'done' flag will
be set and the event list will be disabled by evlist__disable() once.

While in auxtrace_record.read_finish(), the related events will be
enabled again, if they are continuous, the recording seems to be
endless.

If the event is disabled, don't enable it again here.

Based-on-patch-by: Wei Li <liwei391@huawei.com>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Tan Xiaojun <tanxiaojun@huawei.com>
Cc: stable@vger.kernel.org # 5.4+
Link: http://lore.kernel.org/lkml/20200214132654.20395-5-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/arch/arm64/util/arm-spe.c

index eba6541..1d993c2 100644 (file)
@@ -165,9 +165,12 @@ static int arm_spe_read_finish(struct auxtrace_record *itr, int idx)
        struct evsel *evsel;
 
        evlist__for_each_entry(sper->evlist, evsel) {
-               if (evsel->core.attr.type == sper->arm_spe_pmu->type)
+               if (evsel->core.attr.type == sper->arm_spe_pmu->type) {
+                       if (evsel->disabled)
+                               return 0;
                        return perf_evlist__enable_event_idx(sper->evlist,
                                                             evsel, idx);
+               }
        }
        return -EINVAL;
 }