drm/msm: Drop local dma_parms
authorRobin Murphy <robin.murphy@arm.com>
Thu, 3 Sep 2020 21:04:03 +0000 (22:04 +0100)
committerRob Clark <robdclark@chromium.org>
Sat, 12 Sep 2020 16:59:58 +0000 (09:59 -0700)
Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms
for platform devices"), struct platform_device already provides a
dma_parms structure, so we can save allocating another one.

Also the DMA segment size is simply a size, not a bitmask.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/msm_drv.c

index 7933384..8796b7c 100644 (file)
@@ -453,15 +453,7 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
        if (ret)
                goto err_msm_uninit;
 
-       if (!dev->dma_parms) {
-               dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
-                                             GFP_KERNEL);
-               if (!dev->dma_parms) {
-                       ret = -ENOMEM;
-                       goto err_msm_uninit;
-               }
-       }
-       dma_set_max_seg_size(dev, DMA_BIT_MASK(32));
+       dma_set_max_seg_size(dev, UINT_MAX);
 
        msm_gem_shrinker_init(ddev);