livepatch: Remove module_disable_ro() usage
authorJosh Poimboeuf <jpoimboe@redhat.com>
Wed, 29 Apr 2020 15:24:50 +0000 (10:24 -0500)
committerJiri Kosina <jkosina@suse.cz>
Thu, 7 May 2020 22:12:43 +0000 (00:12 +0200)
With arch_klp_init_object_loaded() gone, and apply_relocate_add() now
using text_poke(), livepatch no longer needs to use module_disable_ro().

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
kernel/livepatch/core.c

index f9ebb54..6b8b3c0 100644 (file)
@@ -777,7 +777,6 @@ static int klp_init_object_loaded(struct klp_patch *patch,
        if (klp_is_module(obj)) {
 
                mutex_lock(&text_mutex);
-               module_disable_ro(patch->mod);
 
                /*
                 * Only write module-specific relocations here
@@ -787,7 +786,6 @@ static int klp_init_object_loaded(struct klp_patch *patch,
                 */
                ret = klp_apply_object_relocs(patch, obj);
 
-               module_enable_ro(patch->mod, true);
                mutex_unlock(&text_mutex);
 
                if (ret)