ALSA: ppc/tumbler: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:33 +0000 (08:47 -0600)
committerTakashi Iwai <tiwai@suse.de>
Wed, 19 Apr 2023 06:25:57 +0000 (08:25 +0200)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144733.1546500-1-robh@kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/tumbler.c

index f3f8ad7..6c88287 100644 (file)
@@ -1363,7 +1363,7 @@ int snd_pmac_tumbler_init(struct snd_pmac *chip)
                if (of_node_name_eq(np, "sound")) {
                        if (of_get_property(np, "has-anded-reset", NULL))
                                mix->anded_reset = 1;
-                       if (of_get_property(np, "layout-id", NULL))
+                       if (of_property_present(np, "layout-id"))
                                mix->reset_on_sleep = 0;
                        of_node_put(np);
                        break;