perf: qcom: use DEVICE_ATTR_RO macro
authorYueHaibing <yuehaibing@huawei.com>
Fri, 28 May 2021 01:47:49 +0000 (09:47 +0800)
committerWill Deacon <will@kernel.org>
Tue, 1 Jun 2021 13:23:09 +0000 (14:23 +0100)
Use DEVICE_ATTR_RO() helper instead of plain DEVICE_ATTR(),
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20210528014749.24068-1-yuehaibing@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/qcom_l3_pmu.c

index bba0780..0812735 100644 (file)
@@ -670,15 +670,15 @@ static const struct attribute_group qcom_l3_cache_pmu_events_group = {
 
 /* cpumask */
 
-static ssize_t qcom_l3_cache_pmu_cpumask_show(struct device *dev,
-                                    struct device_attribute *attr, char *buf)
+static ssize_t cpumask_show(struct device *dev,
+                           struct device_attribute *attr, char *buf)
 {
        struct l3cache_pmu *l3pmu = to_l3cache_pmu(dev_get_drvdata(dev));
 
        return cpumap_print_to_pagebuf(true, buf, &l3pmu->cpumask);
 }
 
-static DEVICE_ATTR(cpumask, 0444, qcom_l3_cache_pmu_cpumask_show, NULL);
+static DEVICE_ATTR_RO(cpumask);
 
 static struct attribute *qcom_l3_cache_pmu_cpumask_attrs[] = {
        &dev_attr_cpumask.attr,