projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c0d580c
)
mailbox: mtk-cmdq: Fix uninitialized variable in cmdq_mbox_flush()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Tue, 22 Jun 2021 13:08:52 +0000
(16:08 +0300)
committer
Jassi Brar
<jaswinder.singh@linaro.org>
Sat, 26 Jun 2021 16:41:47 +0000
(11:41 -0500)
The "cb" pointer needs to be initialized before can assign
"data.data = cb->data;".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/mtk-cmdq-mailbox.c
patch
|
blob
|
history
diff --git
a/drivers/mailbox/mtk-cmdq-mailbox.c
b/drivers/mailbox/mtk-cmdq-mailbox.c
index
301e65b
..
67a42b5
100644
(file)
--- a/
drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/
drivers/mailbox/mtk-cmdq-mailbox.c
@@
-455,10
+455,10
@@
static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout)
list_for_each_entry_safe(task, tmp, &thread->task_busy_list,
list_entry) {
+ cb = &task->pkt->async_cb;
data.sta = -ECONNABORTED;
data.data = cb->data;
data.pkt = task->pkt;
- cb = &task->pkt->async_cb;
if (cb->cb)
cb->cb(data);