MIPS: No need to check CPU 0 in {loongson3,bmips,octeon}_cpu_disable()
authorTiezhu Yang <yangtiezhu@loongson.cn>
Wed, 25 Nov 2020 10:11:30 +0000 (18:11 +0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Fri, 27 Nov 2020 09:38:12 +0000 (10:38 +0100)
After commit 9cce844abf07 ("MIPS: CPU#0 is not hotpluggable"),
c->hotpluggable is 0 for CPU 0 and it will not generate a control
file in sysfs for this CPU:

[root@linux loongson]# cat /sys/devices/system/cpu/cpu0/online
cat: /sys/devices/system/cpu/cpu0/online: No such file or directory
[root@linux loongson]# echo 0 > /sys/devices/system/cpu/cpu0/online
bash: /sys/devices/system/cpu/cpu0/online: Permission denied

So no need to check CPU 0 in {loongson3,bmips,octeon}_cpu_disable(),
just remove them.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/cavium-octeon/smp.c
arch/mips/kernel/smp-bmips.c
arch/mips/loongson64/smp.c

index 076db9a..66ce552 100644 (file)
@@ -290,9 +290,6 @@ static int octeon_cpu_disable(void)
 {
        unsigned int cpu = smp_processor_id();
 
-       if (cpu == 0)
-               return -EBUSY;
-
        if (!octeon_bootloader_entry_addr)
                return -ENOTSUPP;
 
index 1dbfb5a..359b176 100644 (file)
@@ -362,9 +362,6 @@ static int bmips_cpu_disable(void)
 {
        unsigned int cpu = smp_processor_id();
 
-       if (cpu == 0)
-               return -EBUSY;
-
        pr_info("SMP: CPU%d is offline\n", cpu);
 
        set_cpu_online(cpu, false);
index aa0cd72..b8c1fc3 100644 (file)
@@ -544,9 +544,6 @@ static int loongson3_cpu_disable(void)
        unsigned long flags;
        unsigned int cpu = smp_processor_id();
 
-       if (cpu == 0)
-               return -EBUSY;
-
        set_cpu_online(cpu, false);
        calculate_cpu_foreign_map();
        local_irq_save(flags);