pwm: rockchip: Simplify rockchip_pwm_get_state()
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Thu, 19 Sep 2019 09:17:27 +0000 (11:17 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 2 Jun 2020 13:50:52 +0000 (15:50 +0200)
The way state->enabled is computed is rather convoluted and hard to
read - both branches of the if() actually do the exact same thing. So
remove the if(), and further simplify "<boolean condition> ? true :
false" to "<boolean condition>".

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-rockchip.c

index 73352e6..eb8c9cb 100644 (file)
@@ -83,12 +83,7 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip,
        state->duty_cycle =  DIV_ROUND_CLOSEST_ULL(tmp, clk_rate);
 
        val = readl_relaxed(pc->base + pc->data->regs.ctrl);
-       if (pc->data->supports_polarity)
-               state->enabled = ((val & enable_conf) != enable_conf) ?
-                                false : true;
-       else
-               state->enabled = ((val & enable_conf) == enable_conf) ?
-                                true : false;
+       state->enabled = (val & enable_conf) == enable_conf;
 
        if (pc->data->supports_polarity && !(val & PWM_DUTY_POSITIVE))
                state->polarity = PWM_POLARITY_INVERSED;