sata: fsl: fix DPRINTK format string
authorArnd Bergmann <arnd@arndb.de>
Fri, 14 May 2021 21:33:57 +0000 (23:33 +0200)
committerJens Axboe <axboe@kernel.dk>
Mon, 17 May 2021 15:12:40 +0000 (09:12 -0600)
Printing an __iomem pointer as %x produces a warning:

drivers/ata/sata_fsl.c: In function 'fsl_sata_set_irq_coalescing':
drivers/ata/sata_fsl.c:316:17: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'void *' [-Werror=format=]
  316 |         DPRINTK("ICC register status: (hcr base: 0x%x) = 0x%x\n",
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  317 |                         hcr_base, ioread32(hcr_base + ICC));
      |                         ~~~~~~~~
      |                         |
      |                         void *

It's not clear why that pointer should be printed here, but if we do,
then using %p is the way to avoid the warnings.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210514213402.691436-1-arnd@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/ata/sata_fsl.c

index d55ee24..e5838b2 100644 (file)
@@ -313,7 +313,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host,
 
        DPRINTK("interrupt coalescing, count = 0x%x, ticks = %x\n",
                        intr_coalescing_count, intr_coalescing_ticks);
-       DPRINTK("ICC register status: (hcr base: 0x%x) = 0x%x\n",
+       DPRINTK("ICC register status: (hcr base: %p) = 0x%x\n",
                        hcr_base, ioread32(hcr_base + ICC));
 }