topology: Fix up build warning in topology_is_visible()
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 Apr 2022 06:26:53 +0000 (08:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Apr 2022 10:53:11 +0000 (12:53 +0200)
Commit aa63a74d4535 ("topology/sysfs: Hide PPIN on systems that do not
support it.") caused a build warning on some configurations:

drivers/base/topology.c: In function 'topology_is_visible':
drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
  158 |         struct device *dev = kobj_to_dev(kobj);

Fix this up by getting rid of the variable entirely.

Fixes: aa63a74d4535 ("topology/sysfs: Hide PPIN on systems that do not support it.")
Cc: Tony Luck <tony.luck@intel.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/r/20220422062653.3899972-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/topology.c

index 706dbf8..ac6ad9a 100644 (file)
@@ -155,9 +155,7 @@ static struct attribute *default_attrs[] = {
 static umode_t topology_is_visible(struct kobject *kobj,
                                   struct attribute *attr, int unused)
 {
-       struct device *dev = kobj_to_dev(kobj);
-
-       if (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id))
+       if (attr == &dev_attr_ppin.attr && !topology_ppin(kobj_to_dev(kobj)->id))
                return 0;
 
        return attr->mode;