mt76: mt7615: fix a precision vs width bug in printk
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 21 Apr 2021 13:14:40 +0000 (16:14 +0300)
committerFelix Fietkau <nbd@nbd.name>
Wed, 21 Apr 2021 18:55:56 +0000 (20:55 +0200)
Precision "%.*s" was intended instead of width "%*s".  The original code
will print garbage from beyond the end of the skb->data.

Fixes: d76d6c3ba2b0 ("mt76: mt7615: limit firmware log message printk to buffer length")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c

index 3c1528e..aa42af9 100644 (file)
@@ -453,7 +453,7 @@ mt7615_mcu_rx_log_message(struct mt7615_dev *dev, struct sk_buff *skb)
                break;
        }
 
-       wiphy_info(mt76_hw(dev)->wiphy, "%s: %*s", type,
+       wiphy_info(mt76_hw(dev)->wiphy, "%s: %.*s", type,
                   (int)(skb->len - sizeof(*rxd)), data);
 }