media: ipu3-cio2: Drop bogus check and error message
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 17 Aug 2020 16:07:31 +0000 (18:07 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 10 Sep 2020 12:19:24 +0000 (14:19 +0200)
pcim_iomap_table() won't fail if previous pcim_iomap_regions() hasn't.
Since we check pcim_iomap_regions() for failure the check close to
pcim_iomap_table() is bogus and not needed.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/intel/ipu3/ipu3-cio2.c

index ad88e8d..867c8e2 100644 (file)
@@ -1712,7 +1712,6 @@ static int cio2_pci_probe(struct pci_dev *pci_dev,
                          const struct pci_device_id *id)
 {
        struct cio2_device *cio2;
-       void __iomem *const *iomap;
        int r;
 
        cio2 = devm_kzalloc(&pci_dev->dev, sizeof(*cio2), GFP_KERNEL);
@@ -1735,13 +1734,7 @@ static int cio2_pci_probe(struct pci_dev *pci_dev,
                return -ENODEV;
        }
 
-       iomap = pcim_iomap_table(pci_dev);
-       if (!iomap) {
-               dev_err(&pci_dev->dev, "failed to iomap table\n");
-               return -ENODEV;
-       }
-
-       cio2->base = iomap[CIO2_PCI_BAR];
+       cio2->base = pcim_iomap_table(pci_dev)[CIO2_PCI_BAR];
 
        pci_set_drvdata(pci_dev, cio2);