clk: ingenic/jz4770: Exit with error if CGU init failed
authorPaul Cercueil <paul@crapouillou.net>
Thu, 13 Feb 2020 16:19:51 +0000 (13:19 -0300)
committerStephen Boyd <sboyd@kernel.org>
Sat, 21 Mar 2020 00:08:40 +0000 (17:08 -0700)
Exit jz4770_cgu_init() if the 'cgu' pointer we get is NULL, since the
pointer is passed as argument to functions later on.

Fixes: 7a01c19007ad ("clk: Add Ingenic jz4770 CGU driver")
Cc: stable@vger.kernel.org
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lkml.kernel.org/r/20200213161952.37460-1-paul@crapouillou.net
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/ingenic/jz4770-cgu.c

index 956dd65..c051ecb 100644 (file)
@@ -432,8 +432,10 @@ static void __init jz4770_cgu_init(struct device_node *np)
 
        cgu = ingenic_cgu_new(jz4770_cgu_clocks,
                              ARRAY_SIZE(jz4770_cgu_clocks), np);
-       if (!cgu)
+       if (!cgu) {
                pr_err("%s: failed to initialise CGU\n", __func__);
+               return;
+       }
 
        retval = ingenic_cgu_register_clocks(cgu);
        if (retval)