ALSA: hda/tas2781: do not reset cur_* values in runtime_suspend
authorGergo Koteles <soyer@irl.hu>
Fri, 8 Mar 2024 17:41:42 +0000 (18:41 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 11 Mar 2024 08:14:39 +0000 (09:14 +0100)
The amplifier doesn't loose register state in software shutdown mode, so
there is no need to reset the cur_* values.

Without these resets, the amplifier can be turned on after
runtime_suspend without waiting for the program and
profile to be restored.

Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
Signed-off-by: Gergo Koteles <soyer@irl.hu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Message-ID: <aa27ae084150988bf6a0ead7e3403bc485d790f8.1709918447.git.soyer@irl.hu>

sound/pci/hda/tas2781_hda_i2c.c

index 750e49f..0e61e87 100644 (file)
@@ -832,7 +832,6 @@ static void tas2781_hda_i2c_remove(struct i2c_client *clt)
 static int tas2781_runtime_suspend(struct device *dev)
 {
        struct tas2781_hda *tas_hda = dev_get_drvdata(dev);
-       int i;
 
        dev_dbg(tas_hda->dev, "Runtime Suspend\n");
 
@@ -843,12 +842,6 @@ static int tas2781_runtime_suspend(struct device *dev)
                tas_hda->priv->playback_started = false;
        }
 
-       for (i = 0; i < tas_hda->priv->ndev; i++) {
-               tas_hda->priv->tasdevice[i].cur_book = -1;
-               tas_hda->priv->tasdevice[i].cur_prog = -1;
-               tas_hda->priv->tasdevice[i].cur_conf = -1;
-       }
-
        mutex_unlock(&tas_hda->priv->codec_lock);
 
        return 0;