io_uring: take compl state from submit state
authorPavel Begunkov <asml.silence@gmail.com>
Fri, 12 Feb 2021 03:23:50 +0000 (03:23 +0000)
committerJens Axboe <axboe@kernel.dk>
Fri, 12 Feb 2021 12:30:25 +0000 (05:30 -0700)
Completion and submission states are now coupled together, it's weird to
get one from argument and another from ctx, do it consistently for
io_req_free_batch(). It's also faster as we already have @state cached
in registers.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 7b19796..8c2613b 100644 (file)
@@ -2417,13 +2417,10 @@ static void io_req_free_batch(struct req_batch *rb, struct io_kiocb *req,
        rb->ctx_refs++;
 
        io_dismantle_req(req);
-       if (state->free_reqs != ARRAY_SIZE(state->reqs)) {
+       if (state->free_reqs != ARRAY_SIZE(state->reqs))
                state->reqs[state->free_reqs++] = req;
-       } else {
-               struct io_comp_state *cs = &req->ctx->submit_state.comp;
-
-               list_add(&req->compl.list, &cs->free_list);
-       }
+       else
+               list_add(&req->compl.list, &state->comp.free_list);
 }
 
 static void io_submit_flush_completions(struct io_comp_state *cs,