nvmem: sprd: Fix return value of sprd_efuse_probe()
authorTiezhu Yang <yangtiezhu@loongson.cn>
Wed, 22 Jul 2020 10:06:52 +0000 (11:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jul 2020 15:12:08 +0000 (17:12 +0200)
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.

Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200722100705.7772-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvmem/sprd-efuse.c

index 925feb2..5952324 100644 (file)
@@ -378,8 +378,8 @@ static int sprd_efuse_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        efuse->base = devm_platform_ioremap_resource(pdev, 0);
                return -ENOMEM;
 
        efuse->base = devm_platform_ioremap_resource(pdev, 0);
-       if (!efuse->base)
-               return -ENOMEM;
+       if (IS_ERR(efuse->base))
+               return PTR_ERR(efuse->base);
 
        ret = of_hwspin_lock_get_id(np, 0);
        if (ret < 0) {
 
        ret = of_hwspin_lock_get_id(np, 0);
        if (ret < 0) {