media: ipu3-cio2: Simplify cleanup code
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 17 Aug 2020 16:07:24 +0000 (18:07 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 10 Sep 2020 12:10:27 +0000 (14:10 +0200)
The code looks more nicer if we use:
while (i--)
instead:
for (i = i - 1; i >= 0; i--)

This would also allow making 'i' unsigned again.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/intel/ipu3/ipu3-cio2.c

index 4e9e348..0f1bbb7 100644 (file)
@@ -847,7 +847,7 @@ static int cio2_vb2_buf_init(struct vb2_buffer *vb)
        unsigned int lops = DIV_ROUND_UP(pages + 1, entries_per_page);
        struct sg_table *sg;
        struct sg_dma_page_iter sg_iter;
-       int i, j;
+       unsigned int i, j;
 
        if (lops <= 0 || lops > CIO2_MAX_LOPS) {
                dev_err(dev, "%s: bad buffer size (%i)\n", __func__,
@@ -887,7 +887,7 @@ static int cio2_vb2_buf_init(struct vb2_buffer *vb)
        b->lop[i][j] = cio2->dummy_page_bus_addr >> PAGE_SHIFT;
        return 0;
 fail:
-       for (i--; i >= 0; i--)
+       while (i--)
                dma_free_coherent(dev, CIO2_PAGE_SIZE,
                                  b->lop[i], b->lop_bus_addr[i]);
        return -ENOMEM;