EDAC: i5400_edac: get rid of some unused vars
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 13 Sep 2019 14:13:41 +0000 (11:13 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 30 Sep 2019 18:41:54 +0000 (15:41 -0300)
There are several temporary unused vars:

drivers/edac/i5400_edac.c: In function ‘i5400_get_mc_regs’:
drivers/edac/i5400_edac.c:1058:6: warning: variable ‘maxdimmperch’ set but not used [-Wunused-but-set-variable]
 1058 |  int maxdimmperch;
      |      ^~~~~~~~~~~~
drivers/edac/i5400_edac.c:1057:6: warning: variable ‘maxch’ set but not used [-Wunused-but-set-variable]
 1057 |  int maxch;
      |      ^~~~~
drivers/edac/i5400_edac.c: In function ‘i5400_init_dimms’:
drivers/edac/i5400_edac.c:1174:6: warning: variable ‘max_dimms’ set but not used [-Wunused-but-set-variable]
 1174 |  int max_dimms;
      |      ^~~~~~~~~
drivers/edac/i5400_edac.c:1173:14: warning: variable ‘channel_count’ set but not used [-Wunused-but-set-variable]
 1173 |  int ndimms, channel_count;
      |              ^~~~~~~~~~~~~

Get rid of them.

Acked-by: Borislav Petkov <bp@alien8.de>
Acked-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/edac/i5400_edac.c

index 52783b9..8c86c6f 100644 (file)
@@ -1054,8 +1054,6 @@ static void i5400_get_mc_regs(struct mem_ctl_info *mci)
        u32 actual_tolm;
        u16 limit;
        int slot_row;
-       int maxch;
-       int maxdimmperch;
        int way0, way1;
 
        pvt = mci->pvt_info;
@@ -1065,9 +1063,6 @@ static void i5400_get_mc_regs(struct mem_ctl_info *mci)
        pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32),
                        &pvt->u.ambase_top);
 
-       maxdimmperch = pvt->maxdimmperch;
-       maxch = pvt->maxch;
-
        edac_dbg(2, "AMBASE= 0x%lx  MAXCH= %d  MAX-DIMM-Per-CH= %d\n",
                 (long unsigned int)pvt->ambase, pvt->maxch, pvt->maxdimmperch);
 
@@ -1170,17 +1165,13 @@ static int i5400_init_dimms(struct mem_ctl_info *mci)
 {
        struct i5400_pvt *pvt;
        struct dimm_info *dimm;
-       int ndimms, channel_count;
-       int max_dimms;
+       int ndimms;
        int mtr;
        int size_mb;
        int  channel, slot;
 
        pvt = mci->pvt_info;
 
-       channel_count = pvt->maxch;
-       max_dimms = pvt->maxdimmperch;
-
        ndimms = 0;
 
        /*