x86/entry/64: Add instruction suffix to SYSRET
authorJan Beulich <jbeulich@suse.com>
Mon, 16 Dec 2019 10:40:03 +0000 (11:40 +0100)
committerBorislav Petkov <bp@suse.de>
Thu, 9 Jan 2020 11:33:43 +0000 (12:33 +0100)
ignore_sysret() contains an unsuffixed SYSRET instruction. gas correctly
interprets this as SYSRETL, but leaving it up to gas to guess when there
is no register operand that implies a size is bad practice, and upstream
gas is likely to warn about this in the future. Use SYSRETL explicitly.
This does not change the assembled output.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Andy Lutomirski <luto@kernel.org>
Link: https://lkml.kernel.org/r/038a7c35-062b-a285-c6d2-653b56585844@suse.com
arch/x86/entry/entry_64.S

index 76942cb..f2bb91e 100644 (file)
@@ -1728,7 +1728,7 @@ SYM_CODE_END(nmi)
 SYM_CODE_START(ignore_sysret)
        UNWIND_HINT_EMPTY
        mov     $-ENOSYS, %eax
-       sysret
+       sysretl
 SYM_CODE_END(ignore_sysret)
 #endif