media: renesas-ceu: keep input name simple
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 23 Sep 2023 15:20:53 +0000 (17:20 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 27 Sep 2023 08:47:22 +0000 (10:47 +0200)
Just show the Camera index as input name in VIDIOC_ENUM_INPUT,
no need to show the subdev name as well as that is meaningless for
users anyway.

This fixes this compiler warning:

drivers/media/platform/renesas/renesas-ceu.c: In function 'ceu_enum_input':
drivers/media/platform/renesas/renesas-ceu.c:1195:59: warning: '%s' directive output may be truncated writing up to 47 bytes into a region of size between 14 and 23 [-Wformat-truncation=]
 1195 |         snprintf(inp->name, sizeof(inp->name), "Camera%u: %s",
      |                                                           ^~
drivers/media/platform/renesas/renesas-ceu.c:1195:9: note: 'snprintf' output between 10 and 66 bytes into a destination of size 32
 1195 |         snprintf(inp->name, sizeof(inp->name), "Camera%u: %s",
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1196 |                  inp->index, ceusd->v4l2_sd->name);
      |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
drivers/media/platform/renesas/renesas-ceu.c

index ec631c6..2562b30 100644 (file)
@@ -1183,17 +1183,13 @@ static int ceu_enum_input(struct file *file, void *priv,
                          struct v4l2_input *inp)
 {
        struct ceu_device *ceudev = video_drvdata(file);
-       struct ceu_subdev *ceusd;
 
        if (inp->index >= ceudev->num_sd)
                return -EINVAL;
 
-       ceusd = ceudev->subdevs[inp->index];
-
        inp->type = V4L2_INPUT_TYPE_CAMERA;
        inp->std = 0;
-       snprintf(inp->name, sizeof(inp->name), "Camera%u: %s",
-                inp->index, ceusd->v4l2_sd->name);
+       snprintf(inp->name, sizeof(inp->name), "Camera %u", inp->index);
 
        return 0;
 }