clk: Use clamp instead of open-coding our own
authorMaxime Ripard <maxime@cerno.tech>
Fri, 25 Feb 2022 14:35:27 +0000 (15:35 +0100)
committerStephen Boyd <sboyd@kernel.org>
Sat, 12 Mar 2022 03:14:40 +0000 (19:14 -0800)
The code in clk_set_rate_range() will, if the current rate is outside of
the new range, force it to the minimum or maximum.

Since it's running under the condition that the rate is either lower
than the minimum, or higher than the maximum, this is equivalent to
using clamp, while being less readable. Let's switch to using clamp
instead.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220225143534.405820-6-maxime@cerno.tech
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk.c

index 6c4e102..c15ee50 100644 (file)
@@ -2388,11 +2388,7 @@ int clk_set_rate_range(struct clk *clk, unsigned long min, unsigned long max)
                 *   this corner case when determining the rate
                 */
 
-               if (rate < min)
-                       rate = min;
-               else
-                       rate = max;
-
+               rate = clamp(clk->core->req_rate, min, max);
                ret = clk_core_set_rate_nolock(clk->core, rate);
                if (ret) {
                        /* rollback the changes */