sparc: Fix handling of page table constructor failure
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Wed, 25 Nov 2020 03:46:54 +0000 (03:46 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Feb 2021 00:30:09 +0000 (16:30 -0800)
The page has just been allocated, so its refcount is 1.  free_unref_page()
is for use on pages which have a zero refcount.  Use __free_page()
like the other implementations of pte_alloc_one().

Fixes: 1ae9ae5f7df7 ("sparc: handle pgtable_page_ctor() fail")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/mm/init_64.c

index 02e6e5e..81c963b 100644 (file)
@@ -2899,7 +2899,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)
        if (!page)
                return NULL;
        if (!pgtable_pte_page_ctor(page)) {
-               free_unref_page(page);
+               __free_page(page);
                return NULL;
        }
        return (pte_t *) page_address(page);