drm/amd/pm: Fix a memory leak in an error handling path in 'vangogh_tables_init()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 5 Aug 2021 18:37:14 +0000 (20:37 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Aug 2021 01:18:00 +0000 (21:18 -0400)
'watermarks_table' must be freed instead 'clocks_table', because
'clocks_table' is known to be NULL at this point and 'watermarks_table' is
never freed if the last kzalloc fails.

Fixes: c98ee89736b8 ("drm/amd/pm: add the fine grain tuning function for vangogh")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c

index 18681dc..bcaaa08 100644 (file)
@@ -256,7 +256,7 @@ static int vangogh_tables_init(struct smu_context *smu)
        return 0;
 
 err3_out:
-       kfree(smu_table->clocks_table);
+       kfree(smu_table->watermarks_table);
 err2_out:
        kfree(smu_table->gpu_metrics_table);
 err1_out: