fsnotify: convert runtime BUG_ON() to BUILD_BUG_ON()
authorAmir Goldstein <amir73il@gmail.com>
Wed, 3 Oct 2018 21:25:36 +0000 (00:25 +0300)
committerJan Kara <jack@suse.cz>
Thu, 4 Oct 2018 11:28:50 +0000 (13:28 +0200)
The BUG_ON() statements to verify number of bits in ALL_FSNOTIFY_BITS
and ALL_INOTIFY_BITS are converted to build time check of the constant.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/notify/fsnotify.c
fs/notify/inotify/inotify_user.c

index 7391a02..8759755 100644 (file)
@@ -395,7 +395,7 @@ static __init int fsnotify_init(void)
 {
        int ret;
 
-       BUG_ON(hweight32(ALL_FSNOTIFY_BITS) != 23);
+       BUILD_BUG_ON(HWEIGHT32(ALL_FSNOTIFY_BITS) != 23);
 
        ret = init_srcu_struct(&fsnotify_mark_srcu);
        if (ret)
index ac6978d..105576d 100644 (file)
@@ -815,7 +815,7 @@ static int __init inotify_user_setup(void)
        BUILD_BUG_ON(IN_ISDIR != FS_ISDIR);
        BUILD_BUG_ON(IN_ONESHOT != FS_IN_ONESHOT);
 
-       BUG_ON(hweight32(ALL_INOTIFY_BITS) != 22);
+       BUILD_BUG_ON(HWEIGHT32(ALL_INOTIFY_BITS) != 22);
 
        inotify_inode_mark_cachep = KMEM_CACHE(inotify_inode_mark,
                                               SLAB_PANIC|SLAB_ACCOUNT);