RDMA/qedr: Remove in_irq() usage from debug output
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Mon, 8 Feb 2021 19:33:47 +0000 (20:33 +0100)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 9 Feb 2021 00:43:11 +0000 (20:43 -0400)
qedr_gsi_post_send() has a debug output which prints the return value of
in_irq() and irqs_disabled().

The result of the in_irq(), even if invoked from an interrupt handler, is
subject to change depending on the `threadirqs' command line switch.  The
result of irqs_disabled() is always be 1 because the function acquires
spinlock_t with spin_lock_irqsave().

Remove in_irq() and irqs_disabled() from the debug output because it
provides little value.

Link: https://lore.kernel.org/r/20210208193347.383254-1-bigeasy@linutronix.de
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/qedr/qedr_roce_cm.c

index f5542d7..13e5e6b 100644 (file)
@@ -586,8 +586,8 @@ int qedr_gsi_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr,
                qp->wqe_wr_id[qp->sq.prod].wr_id = wr->wr_id;
                qedr_inc_sw_prod(&qp->sq);
                DP_DEBUG(qp->dev, QEDR_MSG_GSI,
-                        "gsi post send: opcode=%d, in_irq=%ld, irqs_disabled=%d, wr_id=%llx\n",
-                        wr->opcode, in_irq(), irqs_disabled(), wr->wr_id);
+                        "gsi post send: opcode=%d, wr_id=%llx\n", wr->opcode,
+                        wr->wr_id);
        } else {
                DP_ERR(dev, "gsi post send: failed to transmit (rc=%d)\n", rc);
                rc = -EAGAIN;