nvmet: use unsigned type for u64
authorChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Fri, 12 Jun 2020 01:16:59 +0000 (18:16 -0700)
committerChristoph Hellwig <hch@lst.de>
Wed, 8 Jul 2020 14:16:17 +0000 (16:16 +0200)
In function nvmet_subsys_atte_version_show() which uses the NVME_XXX()
macros related to version (of type u64) get rid of the int type cast
when printing subsys version and use appropriate format specifier for
u64.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/configfs.c

index 419e0d4..cdec47d 100644 (file)
@@ -862,14 +862,14 @@ static ssize_t nvmet_subsys_attr_version_show(struct config_item *item,
        struct nvmet_subsys *subsys = to_subsys(item);
 
        if (NVME_TERTIARY(subsys->ver))
-               return snprintf(page, PAGE_SIZE, "%d.%d.%d\n",
-                               (int)NVME_MAJOR(subsys->ver),
-                               (int)NVME_MINOR(subsys->ver),
-                               (int)NVME_TERTIARY(subsys->ver));
-
-       return snprintf(page, PAGE_SIZE, "%d.%d\n",
-                       (int)NVME_MAJOR(subsys->ver),
-                       (int)NVME_MINOR(subsys->ver));
+               return snprintf(page, PAGE_SIZE, "%llu.%llu.%llu\n",
+                               NVME_MAJOR(subsys->ver),
+                               NVME_MINOR(subsys->ver),
+                               NVME_TERTIARY(subsys->ver));
+
+       return snprintf(page, PAGE_SIZE, "%llu.%llu\n",
+                       NVME_MAJOR(subsys->ver),
+                       NVME_MINOR(subsys->ver));
 }
 
 static ssize_t nvmet_subsys_attr_version_store(struct config_item *item,